Fix adding element to multiline array after inline array in yaml#1665
Open
pincher2012 wants to merge 2 commits intosymfony:1.xfrom
Open
Fix adding element to multiline array after inline array in yaml#1665pincher2012 wants to merge 2 commits intosymfony:1.xfrom
pincher2012 wants to merge 2 commits intosymfony:1.xfrom
Conversation
pincher2012
force-pushed
the
yaml-array-bug
branch
from
1181efc to
62d6926
Compare
pincher2012
force-pushed
the
yaml-array-bug
branch
3 times, most recently
from
310f1dc to
46ce4e8
Compare
pincher2012
changed the title
pincher2012
changed the title
GromNaN
reviewed
Feb 4, 2026
| messenger: | ||
| routing: | ||
| App\Messages\OldMessage: [ transport1, transport2 ] | ||
| App\Messages\NewMessage: async No newline at end of file |
Member
There was a problem hiding this comment.
I understand the missing newline at EOF is related to the issue.
What do you think of making YamlSourceManipulator always ensure there is an empty newline at EOF? That is our style rules.
Suggested change
| App\Messages\NewMessage: async | |
| App\Messages\NewMessage: async | |
Author
There was a problem hiding this comment.
Thanks for the review!
Personally, I prefer to leave a new line at the end of the file.
I think this bundle could be used in codebases that might not adhere to the generally accepted style in symfony. Should we impose any formatting rules on the user?
pincher2012
force-pushed
the
yaml-array-bug
branch
from
46ce4e8 to
9d68798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1666